feat: GetExceptionsByReportDate #1495
Merged
Warren-Pitterson merged 34 commits intomainfrom Sep 2, 2025
Merged
Conversation
…yReportDate logic, added GetQueryParameterAsDateTime in helper class,
…om/NHSDigital/dtos-cohort-manager into feat/DTOSS-10556-Exception-Reports
…category and date correctly
Contributor
Author
|
@chrimesdev queryParams are in the description, i've done some DEV testing with it, and all unit tests are passing |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds report-based filtering functionality for validation exceptions by implementing the GetExceptionsByReportDate method. The feature allows filtering exceptions by specific date ranges and categories (Confusion/Superseded).
- Added
GetReportExceptionsmethod to filter validation exceptions by date and categories 12 (Confusion) and 13 (Superseded) - Implemented
GetQueryParameterAsDateTimehelper method with support for multiple date formats - Added comprehensive test coverage for various filtering scenarios
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ValidationExceptionDataTests.cs | Added test data and comprehensive test methods for report exception filtering scenarios |
| GetValidationExceptions.cs | Enhanced function to handle report requests with date/category filtering and improved documentation |
| ValidationExceptionData.cs | Implemented GetReportExceptions method with filtering logic for categories 12/13 and date ranges |
| IValidationExceptionData.cs | Added interface method for GetReportExceptions |
| PaginationService.cs | Refactored default ID selector with null-coalescing operators |
| IHttpParserHelper.cs | Added interface method for DateTime parameter parsing |
| HttpParserHelper.cs | Implemented GetQueryParameterAsDateTime with multiple format support and error logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Looking good, in the response is it possible to return the |
chrimesdev
reviewed
Aug 28, 2025
- Move date filtering to database query to reduce memory usage - Throw exception for null ID values instead of defaulting to 0
…eportExceptions refactor for details
…om/NHSDigital/dtos-cohort-manager into feat/DTOSS-10556-Exception-Reports
|
Contributor
Author
Exception Details object has been added |
SamAinsworth-NHS
approved these changes
Sep 2, 2025
stephhou
pushed a commit
that referenced
this pull request
Sep 5, 2025
* feat: added ReportDate Query Param, updated XML, added GetExceptionsByReportDate logic, added GetQueryParameterAsDateTime in helper class, * test: GetExceptionsByReportDate Tests * feat: format provider added to helper method * chore: sonarQube warnings and default value * feat: isReport added, GetReportExceptions logic changed to filter by category and date correctly * fix: default value already applied to helper method, removed * test: tests added * chore: renamed variable * feat: abstract logic * chore: XML docs * chore: ternary operator formatting * fix: logic error in GetReportExceptions * fix: date fix * fix: category logic fix * refactor: refactor and tidy up GetReportExceptions method * test: updated tests * fix: improve query performance and null ID handling - Move date filtering to database query to reduce memory usage - Throw exception for null ID values instead of defaulting to 0 * chore: removed unused variable * tests: update tests * chore: tidy null check * chore: removed unused variable * feat: exception Details added, Pagination fixed for non reports, GetReportExceptions refactor for details * test: test date * fix: renamed BuildNavigationHeaders to AddNavigationHeaders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added reportDate parameter with date validation
GetExceptionsByReportDate method filtering categories 12 (Confusion) and 13 (Superseded)
Added GetQueryParameterAsDateTime
Filter by Category & Date
Filter by Category
Filter by Date
All category 12 & 13 records
Context
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10556
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.